qapi block: Elide redundant has_FOO in generated C
commit54fde4ff0621c22b15cbaaa3c74301cc0dbd1c9e
authorMarkus Armbruster <armbru@redhat.com>
Fri, 4 Nov 2022 16:06:52 +0000 (4 17:06 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 14 Dec 2022 19:03:25 +0000 (14 20:03 +0100)
tree373c23134aab19ba0edf43249e7722eea1d01d14
parent8461b4d60153ba923c47b6e2f9e270c0e8d6d49c
qapi block: Elide redundant has_FOO in generated C

The has_FOO for pointer-valued FOO are redundant, except for arrays.
They are also a nuisance to work with.  Recent commit "qapi: Start to
elide redundant has_FOO in generated C" provided the means to elide
them step by step.  This is the step for qapi/block*.json.

Said commit explains the transformation in more detail.

There is one instance of the invariant violation mentioned there:
qcow2_signal_corruption() passes false, "" when node_name is an empty
string.  Take care to pass NULL then.

The previous two commits cleaned up two more.

Additionally, helper bdrv_latency_histogram_stats() loses its output
parameters and returns a value instead.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Cc: qemu-block@nongnu.org
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20221104160712.3005652-11-armbru@redhat.com>
[Fixes for #ifndef LIBRBD_SUPPORTS_ENCRYPTION and MacOS squashed in]
23 files changed:
block/block-backend.c
block/copy-before-write.c
block/dirty-bitmap.c
block/export/export.c
block/export/vduse-blk.c
block/gluster.c
block/monitor/block-hmp-cmds.c
block/qapi-sysemu.c
block/qapi.c
block/qcow.c
block/qcow2.c
block/qed.c
block/quorum.c
block/rbd.c
block/ssh.c
blockdev-nbd.c
blockdev.c
blockjob.c
monitor/hmp-cmds.c
qemu-img.c
qemu-nbd.c
scripts/qapi/schema.py
ui/cocoa.m