readline: don't free completions in readline_free()
commit4183e2ea6d092ea9d7f18af085cb1076fae08512
authorGreg Kurz <groug@kaod.org>
Thu, 18 Jan 2018 10:41:03 +0000 (18 11:41 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 5 Feb 2018 12:54:39 +0000 (5 13:54 +0100)
tree82bb2e98bdf99acff21da2dde27b7c54b080f272
parent4e4b57342e14f260ca6e2d4cfcbafb876d227909
readline: don't free completions in readline_free()

Since commit e5dc1a6c6c43, QEMU aborts on exit if completion was used
in the monitor:

*** Error in `obj/ppc64-softmmu/qemu-system-ppc64': double free or
 corruption (fasttop): 0x00000100331069d0 ***

 /home/greg/Work/qemu/qemu-spapr/util/readline.c:514
 /home/greg/Work/qemu/qemu-spapr/monitor.c:586
 /home/greg/Work/qemu/qemu-spapr/monitor.c:4125
 argv=<optimized out>, envp=<optimized out>) at
 /home/greg/Work/qemu/qemu-spapr/vl.c:4795

Completion strings are not persistent accross completions (why would
they?). They are allocated under readline_completion(), which already
takes care of freeing them before returning.

Maybe all completion related bits should be moved out of ReadLineState
to a dedicated structure ?

In the meantime, let's drop the offending lines from readline_free()
to fix the crash.

Signed-off-by: Greg Kurz <groug@kaod.org>
Message-Id: <151627206353.4505.4602428849861610759.stgit@bahia.lan>
Fixes: e5dc1a6c6c43
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
util/readline.c