| commit | 333024140730c9294dafb4158e396faeb4b3f6fe | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 1 Feb 2022 19:32:06 +0000 (1 19:32 +0000) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Tue, 8 Feb 2022 10:56:29 +0000 (8 10:56 +0000) | ||
| tree | 9d4afe0a6a21d9b42299d390b3e83983b8f95a10 | treesnapshot (tar.gz zip) |
| parent | 84d43d2e82dad29db43a96c2ef22606ce834b248 | commitdiff |
hw/intc/arm_gicv3_its: Don't allow intid 1023 in MAPI/MAPTI
When handling MAPI/MAPTI, we allow the supplied interrupt ID to be
either 1023 or something in the valid LPI range. This is a mistake:
only a real valid LPI is allowed. (The general behaviour of the ITS
is that most interrupt ID fields require a value in the LPI range;
the exception is that fields specifying a doorbell value, which are
all in GICv4 commands, allow also 1023 to mean "no doorbell".)
Remove the condition that incorrectly allows 1023 here.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220201193207.2771604-13-peter.maydell@linaro.org
When handling MAPI/MAPTI, we allow the supplied interrupt ID to be
either 1023 or something in the valid LPI range. This is a mistake:
only a real valid LPI is allowed. (The general behaviour of the ITS
is that most interrupt ID fields require a value in the LPI range;
the exception is that fields specifying a doorbell value, which are
all in GICv4 commands, allow also 1023 to mean "no doorbell".)
Remove the condition that incorrectly allows 1023 here.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20220201193207.2771604-13-peter.maydell@linaro.org
| hw/intc/arm_gicv3_its.c | diffblobblamehistory |