qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.
commit2adf2164918e2dc74fef2cdd0257917aff488640
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 1 Jun 2021 13:24:02 +0000 (1 15:24 +0200)
committerStefan Hajnoczi <stefanha@redhat.com>
Mon, 12 Jul 2021 16:37:06 +0000 (12 17:37 +0100)
treef874428fe91a1030d8256b94854d28fca0c61c7a
parentbd38ae26cea0d1d6a97f930248df149204c210a2
qemu-trace-stap: changing SYSTEMTAP_TAPSET considered harmful.

Setting SYSTEMTAP_TAPSET to some value other than
/usr/share/systemtap/tapsets results in systemtap not finding the
standard tapset library any more, which in turn breaks tracing because
pid() and other standard systemtap functions are not available any more.

So using SYSTEMTAP_TAPSET to point systemtap to the qemu probes will
only work for the prefix=/usr installs because both qemu and system
tapsets in the same directory then.  All other prefixes are broken.

Fix that by using the "-I $tapsetdir" command line switch instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-id: 20210601132414.432430-2-kraxel@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
scripts/qemu-trace-stap