block: Silence Coverity in bdrv_drop_intermediate()
commit2345bde647a179ac88723e8e0c2fc1643b3a7a7e
authorKevin Wolf <kwolf@redhat.com>
Fri, 15 Mar 2019 11:15:16 +0000 (15 12:15 +0100)
committerKevin Wolf <kwolf@redhat.com>
Tue, 19 Mar 2019 14:49:29 +0000 (19 15:49 +0100)
tree11ed9c2d64fb45ed6e2c386a5ad87655df318fa3
parentb69864e5a8c7b762e94d1bfd170b8774b28ab993
block: Silence Coverity in bdrv_drop_intermediate()

Coverity doesn't like that the return value of bdrv_check_update_perm()
stays unused only in this place (CID 1399710).

Even if checking local_err should be equivalent to checking ret < 0,
let's switch to using the return value to be more consistent (and in
case of a bug somewhere down the call chain, forgetting to assign errp
is more likely than returning 0 for an error case).

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
block.c