| commit | 1f089c6705fdb0da1b6def842ecf323b07a4460f | |
| author | Alex Bennée <alex.bennee@linaro.org> | |
| Fri, 3 Apr 2020 19:11:43 +0000 (3 20:11 +0100) | ||
| committer | Alex Bennée <alex.bennee@linaro.org> | |
| Tue, 7 Apr 2020 15:19:49 +0000 (7 16:19 +0100) | ||
| tree | 1f063420899505aa2b6d0f1b37e51bb956ae92c2 | treesnapshot (tar.gz zip) |
| parent | b859040dc44b271e9ad29f729cac71d2389b05fd | commitdiff |
target/xtensa: add FIXME for translation memory leak
Dynamically allocating a new structure within the DisasContext can
potentially leak as we can longjmp out of the translation loop (see
test_phys_mem). The proper fix would be to use static allocation
within the DisasContext but as the Xtensa translator imports it's code
from elsewhere I leave that as an exercise for the maintainer.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200403191150.863-6-alex.bennee@linaro.org>
Dynamically allocating a new structure within the DisasContext can
potentially leak as we can longjmp out of the translation loop (see
test_phys_mem). The proper fix would be to use static allocation
within the DisasContext but as the Xtensa translator imports it's code
from elsewhere I leave that as an exercise for the maintainer.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Acked-by: Max Filippov <jcmvbkbc@gmail.com>
Message-Id: <20200403191150.863-6-alex.bennee@linaro.org>
| target/xtensa/translate.c | diffblobblamehistory |