| commit | 1677f4c66cf2228eb14f1b0571d0e3b38d0d6606 | |
| author | Markus Armbruster <armbru@redhat.com> | |
| Mon, 9 Feb 2015 13:03:19 +0000 (9 14:03 +0100) | ||
| committer | Markus Armbruster <armbru@redhat.com> | |
| Wed, 18 Feb 2015 09:51:28 +0000 (18 10:51 +0100) | ||
| tree | 7c103f0cc73fd4c8eb6e8a70483e740377cd4229 | treesnapshot (tar.gz zip) |
| parent | 565f65d271984a32eed2c324ff6ef8be33f7f3d2 | commitdiff |
monitor: Clean up around monitor_handle_fd_param()
monitor_handle_fd_param() is a wrapper around
monitor_handle_fd_param2() that feeds errors to qerror_report_err()
instead of returning them. qerror_report_err() is inappropriate in
many contexts. monitor_handle_fd_param() looks simpler than
monitor_handle_fd_param2(), which tempts use. Remove the temptation:
drop the wrapper and open-code the (trivial) error handling instead.
Replace the open-coded qerror_report_err() by error_report_err() in
places that already use error_report(). Turns out that's everywhere.
While there, rename monitor_handle_fd_param2() to monitor_fd_param().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
monitor_handle_fd_param() is a wrapper around
monitor_handle_fd_param2() that feeds errors to qerror_report_err()
instead of returning them. qerror_report_err() is inappropriate in
many contexts. monitor_handle_fd_param() looks simpler than
monitor_handle_fd_param2(), which tempts use. Remove the temptation:
drop the wrapper and open-code the (trivial) error handling instead.
Replace the open-coded qerror_report_err() by error_report_err() in
places that already use error_report(). Turns out that's everywhere.
While there, rename monitor_handle_fd_param2() to monitor_fd_param().
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>