| commit | 127c84e1a52f11bf418cc2d3bf804da5091a190a | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Fri, 23 Aug 2013 16:35:45 +0000 (23 17:35 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Fri, 30 Aug 2013 13:28:52 +0000 (30 15:28 +0200) | ||
| tree | 3e8da209b2e6ee46ae6524564135da4ed62393be | treesnapshot (tar.gz zip) |
| parent | cccc30b4ad5d9835f5525d94210c8de26f4f5f94 | commitdiff |
block/qcow2.h: Avoid "1LL << 63" (shifts into sign bit)
The expression "1LL << 63" tries to shift the 1 into the sign bit of a
'long long', which provokes a clang sanitizer warning:
runtime error: left shift of 1 by 63 places cannot be represented in type 'long long'
Use "1ULL << 63" as the definition of QCOW_OFLAG_COPIED instead
to avoid this. For consistency, we also update the other QCOW_OFLAG
definitions to use the ULL suffix rather than LL, though only the
shift by 63 is undefined behaviour.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
The expression "1LL << 63" tries to shift the 1 into the sign bit of a
'long long', which provokes a clang sanitizer warning:
runtime error: left shift of 1 by 63 places cannot be represented in type 'long long'
Use "1ULL << 63" as the definition of QCOW_OFLAG_COPIED instead
to avoid this. For consistency, we also update the other QCOW_OFLAG
definitions to use the ULL suffix rather than LL, though only the
shift by 63 is undefined behaviour.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
| block/qcow2.h | diffblobblamehistory |