| commit | 118eee6ceeaa2b6dd007115ec65ae486e4dee4ed | |
| author | Eric Auger <eric.auger@redhat.com> | |
| Fri, 18 May 2018 16:48:07 +0000 (18 17:48 +0100) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Fri, 18 May 2018 16:48:07 +0000 (18 17:48 +0100) | ||
| tree | 3d77164788e4c5d67ec65587018845bc7c624422 | treesnapshot (tar.gz zip) |
| parent | 24af32e049684827286e24114a066e09d0dcdaaf | commitdiff |
hw/arm/smmu-common: Fix coverity issue in get_block_pte_address
Coverity points out that this can overflow if n > 31,
because it's only doing 32-bit arithmetic. Let's use 1ULL instead
of 1. Also the formulae used to compute n can be replaced by
the level_shift() macro.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 1526493784-25328-3-git-send-email-eric.auger@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Coverity points out that this can overflow if n > 31,
because it's only doing 32-bit arithmetic. Let's use 1ULL instead
of 1. Also the formulae used to compute n can be replaced by
the level_shift() macro.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 1526493784-25328-3-git-send-email-eric.auger@redhat.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
| hw/arm/smmu-common.c | diffblobblamehistory |