| commit | 0debf1400c000154948e8a6fcb89c3149d4e0880 | |
| author | Philippe Mathieu-Daudé <f4bug@amsat.org> | |
| Mon, 19 Apr 2021 16:00:55 +0000 (19 18:00 +0200) | ||
| committer | Philippe Mathieu-Daudé <f4bug@amsat.org> | |
| Sun, 2 May 2021 14:49:34 +0000 (2 16:49 +0200) | ||
| tree | 9494e85cc911d294917767c6cd7d971937aca724 | treesnapshot (tar.gz zip) |
| parent | 533fc64feb96b6aafdb0d604cd1cd97877451878 | commitdiff |
target/mips: Merge do_translate_address into cpu_mips_translate_address
Currently cpu_mips_translate_address() calls raise_mmu_exception(),
and do_translate_address() calls cpu_loop_exit_restore().
This API split is dangerous, we could call cpu_mips_translate_address
without returning to the main loop.
As there is only one caller, it is trivial (and safer) to merge
do_translate_address() back to cpu_mips_translate_address().
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210428170410.479308-10-f4bug@amsat.org>
Currently cpu_mips_translate_address() calls raise_mmu_exception(),
and do_translate_address() calls cpu_loop_exit_restore().
This API split is dangerous, we could call cpu_mips_translate_address
without returning to the main loop.
As there is only one caller, it is trivial (and safer) to merge
do_translate_address() back to cpu_mips_translate_address().
Reported-by: Richard Henderson <richard.henderson@linaro.org>
Suggested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20210428170410.479308-10-f4bug@amsat.org>
| target/mips/internal.h | diffblobblamehistory | |
| target/mips/op_helper.c | diffblobblamehistory | |
| target/mips/tlb_helper.c | diffblobblamehistory |