| commit | 05ea385afdfe5d0886265880bfd14d17192beb03 | |
| author | Max Reitz <mreitz@redhat.com> | |
| Tue, 11 Jun 2019 19:19:26 +0000 (11 21:19 +0200) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Mon, 7 Sep 2020 10:31:31 +0000 (7 12:31 +0200) | ||
| tree | c4fa1cb6bf4cdf5be2e4349c139b46791e3a7ab1 | treesnapshot (tar.gz zip) |
| parent | f1a7f18f07ef41b4d078621bd6e515165106d91f | commitdiff |
blockdev: Fix active commit choice
We have to perform an active commit whenever the top node has a parent
that has taken the WRITE permission on it.
This means that block-commit's @backing-file parameter is no longer
allowed for such nodes, and that users will have to issue a
block-job-complete command. Neither should pose a problem in practice,
because this case was basically just broken until now.
(Since this commit already touches block-commit's documentation, it also
moves up the chunk explaining general block-commit behavior that for
some reason was situated under @backing-file.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
We have to perform an active commit whenever the top node has a parent
that has taken the WRITE permission on it.
This means that block-commit's @backing-file parameter is no longer
allowed for such nodes, and that users will have to issue a
block-job-complete command. Neither should pose a problem in practice,
because this case was basically just broken until now.
(Since this commit already touches block-commit's documentation, it also
moves up the chunk explaining general block-commit behavior that for
some reason was situated under @backing-file.)
Signed-off-by: Max Reitz <mreitz@redhat.com>
| blockdev.c | diffblobblamehistory | |
| qapi/block-core.json | diffblobblamehistory |