From c66a4e995e28fc37a760cf1c42a7c7ac35fde9d8 Mon Sep 17 00:00:00 2001 From: Alex Williamson Date: Tue, 12 May 2009 22:45:11 -0600 Subject: [PATCH] device-assignment: Fix kvm_get_irq_route_gsi() return check Use 'r' for the return value since gsi is unsigned. Signed-off-by: Alex Williamson Signed-off-by: Avi Kivity --- hw/device-assignment.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index 0a5f8501b2..853307bff6 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -776,11 +776,12 @@ static void assigned_dev_update_msi(PCIDevice *pci_dev, unsigned int ctrl_pos) assigned_dev->entry->u.msi.data = *(uint16_t *)(pci_dev->config + pci_dev->cap.start + PCI_MSI_DATA_32); assigned_dev->entry->type = KVM_IRQ_ROUTING_MSI; - assigned_dev->entry->gsi = kvm_get_irq_route_gsi(kvm_context); - if (assigned_dev->entry->gsi < 0) { + r = kvm_get_irq_route_gsi(kvm_context); + if (r < 0) { perror("assigned_dev_update_msi: kvm_get_irq_route_gsi"); return; } + assigned_dev->entry->gsi = r; kvm_add_routing_entry(kvm_context, assigned_dev->entry); if (kvm_commit_irq_routes(kvm_context) < 0) { -- 2.11.4.GIT