| commit | f47c3f5a800a927238d20de9f99b5c77f0bc3fe0 | |
| author | Kevin Wolf <kwolf@redhat.com> | |
| Wed, 5 Mar 2014 14:45:00 +0000 (5 15:45 +0100) | ||
| committer | Kevin Wolf <kwolf@redhat.com> | |
| Wed, 5 Mar 2014 15:58:20 +0000 (5 16:58 +0100) | ||
| tree | c36a93d6af8e3a450132d95acf8c582bc00866d6 | treesnapshot (tar.gz zip) |
| parent | 2fa4c042bc55ec10b9ca16163697d02cddd2d768 | commitdiff |
iscsi: Use bs->sg for everything else than disks
The current iscsi block driver code makes the rather arbitrary decision
that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all
other device types are disks.
Instead of this, check for TYPE_DISK to expose the disk interface and
make everything else bs->sg = 1. In particular, this includes devices
with TYPE_STORAGE_ARRAY, which is what LUN 0 of an iscsi target is.
(See https://bugzilla.redhat.com/show_bug.cgi?id=1067784 for the exact
scenario.)
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
The current iscsi block driver code makes the rather arbitrary decision
that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all
other device types are disks.
Instead of this, check for TYPE_DISK to expose the disk interface and
make everything else bs->sg = 1. In particular, this includes devices
with TYPE_STORAGE_ARRAY, which is what LUN 0 of an iscsi target is.
(See https://bugzilla.redhat.com/show_bug.cgi?id=1067784 for the exact
scenario.)
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Benoit Canet <benoit@irqsave.net>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
| block/iscsi.c | diffblobblamehistory |