| commit | 949013ce111eb64f8bc81cf9a9f1cefd6a1678c3 | |
| author | Peter Maydell <peter.maydell@linaro.org> | |
| Thu, 5 Feb 2015 13:37:23 +0000 (5 13:37 +0000) | ||
| committer | Peter Maydell <peter.maydell@linaro.org> | |
| Thu, 5 Feb 2015 13:37:23 +0000 (5 13:37 +0000) | ||
| tree | e68685f3d33528f91c5a977ce9c69ec0fc202a26 | treesnapshot (tar.gz zip) |
| parent | 6d54ed3c93f1e05a483201b087142998381c9be8 | commitdiff |
target-arm/translate-a64: Fix wrong mmu_idx usage for LDT/STT
The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege". This went unnoticed because AArch64 Linux doesn't use
these instructions.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Bellows <greg.bellows@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
I'm not counting this as a security issue because I'm assuming
nobody treats TCG guests as a security boundary (certainly I
would not recommend doing so...)
The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege". This went unnoticed because AArch64 Linux doesn't use
these instructions.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Greg Bellows <greg.bellows@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
I'm not counting this as a security issue because I'm assuming
nobody treats TCG guests as a security boundary (certainly I
would not recommend doing so...)
| target-arm/translate-a64.c | diffblobblamehistory |