| commit | 352fa88dfb2e9c72fa2a1506acb39f349d4befbf | |
| author | Gonglei <arei.gonglei@huawei.com> | |
| Tue, 30 Sep 2014 06:10:34 +0000 (30 14:10 +0800) | ||
| committer | Paolo Bonzini <pbonzini@redhat.com> | |
| Tue, 30 Sep 2014 09:09:24 +0000 (30 11:09 +0200) | ||
| tree | 7a7dfc82da3db4fe8ce69b97274f3fbb88a91acd | treesnapshot (tar.gz zip) |
| parent | 8ee486ae339f0e5236f4a9ab988fc963edcc73b5 | commitdiff |
virtio-rng: fix virtio-rng child refcount in transports
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-rng child is not finalized!
Drop our reference after the child property has been added to the
parent.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
object_initialize() leaves the object with a refcount of 1.
object_property_add_child() adds its own reference which is dropped
again when the property is deleted.
The upshot of this is that we always have a refcount >= 1. Upon hot
unplug the virtio-rng child is not finalized!
Drop our reference after the child property has been added to the
parent.
Signed-off-by: Gonglei <arei.gonglei@huawei.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
| hw/s390x/s390-virtio-bus.c | diffblobblamehistory | |
| hw/s390x/virtio-ccw.c | diffblobblamehistory | |
| hw/virtio/virtio-pci.c | diffblobblamehistory |