slirp: udp: fix NULL pointer dereference because of uninitialized socket
commit01f7cecf0037997cb0e58ec0d56bf9b5a6f7cb2a
authorPetr Matousek <pmatouse@redhat.com>
Thu, 18 Sep 2014 06:35:37 +0000 (18 08:35 +0200)
committerPeter Maydell <peter.maydell@linaro.org>
Tue, 23 Sep 2014 18:15:05 +0000 (23 19:15 +0100)
treea3bb364b0bcc76ffcb54ed0acaa0f39fd382e997
parent769188d3bbf95ce8d96a335624234dad083f4db6
slirp: udp: fix NULL pointer dereference because of uninitialized socket

When guest sends udp packet with source port and source addr 0,
uninitialized socket is picked up when looking for matching and already
created udp sockets, and later passed to sosendto() where NULL pointer
dereference is hit during so->slirp->vnetwork_mask.s_addr access.

Fix this by checking that the socket is not just a socket stub.

This is CVE-2014-3640.

Signed-off-by: Petr Matousek <pmatouse@redhat.com>
Reported-by: Xavier Mehrenberger <xavier.mehrenberger@airbus.com>
Reported-by: Stephane Duverger <stephane.duverger@eads.net>
Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Message-id: 20140918063537.GX9321@dhcp-25-225.brq.redhat.com
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
slirp/udp.c