| commit | c1e7c3ae59b065bf7ff24a05cb609b2f9e314db6 | |
| author | Phillip Lougher <phillip@lougher.demon.co.uk> | |
| Mon, 14 Dec 2009 21:45:19 +0000 (14 21:45 +0000) | ||
| committer | H. Peter Anvin <hpa@zytor.com> | |
| Tue, 15 Dec 2009 22:04:12 +0000 (15 14:04 -0800) | ||
| tree | b75700eb5160c026761f20e74010406a7fe58bec | treesnapshot (tar.gz zip) |
| parent | 23637568ad0c9b5ab0ad27d2f2f26d1e9282c527 | commitdiff |
bzip2/lzma/gzip: pre-boot malloc doesn't return NULL on failure
The trivial malloc implementation used in the pre-boot environment by the
decompressors returns a bad pointer on failure (falling through after
calling error). This is doubly wrong - the callers expect malloc to
return NULL on failure, second the error function is intended to be
used by the decompressors to propagate errors to *their* callers. The
decompressors have no access to any state set by the error function.
Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
LKML-Reference: <4b26b1ef.hIInb2AYPMtImAJO%phillip@lougher.demon.co.uk>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
The trivial malloc implementation used in the pre-boot environment by the
decompressors returns a bad pointer on failure (falling through after
calling error). This is doubly wrong - the callers expect malloc to
return NULL on failure, second the error function is intended to be
used by the decompressors to propagate errors to *their* callers. The
decompressors have no access to any state set by the error function.
Signed-off-by: Phillip Lougher <phillip@lougher.demon.co.uk>
LKML-Reference: <4b26b1ef.hIInb2AYPMtImAJO%phillip@lougher.demon.co.uk>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
| include/linux/decompress/mm.h | diffblobblamehistory |