| commit | 7b4ffcf953f091a815df081911c5e75c8a38418d | |
| author | Phil Carmody <ext-phil.2.carmody@nokia.com> | |
| Fri, 24 Jul 2009 05:59:17 +0000 (24 13:59 +0800) | ||
| committer | Herbert Xu <herbert@gondor.apana.org.au> | |
| Fri, 24 Jul 2009 05:59:17 +0000 (24 13:59 +0800) | ||
| tree | 9592ddafb6399806b3e1bbfe86333572ed782e9a | treesnapshot (tar.gz zip) |
| parent | 0044f3eda9a778ab63c2a5eafede3803f01b0b97 | commitdiff |
crypto: aes - Undefined behaviour in crypto_aes_expand_key
It's undefined behaviour in C to write outside the bounds of an array.
The key expansion routine takes a shortcut of creating 8 words at a
time, but this creates 4 additional words which don't fit in the array.
As everyone is hopefully now aware, GCC is at liberty to make any
assumptions and optimisations it likes in situations where it can
detect that UB has occured, up to and including nasal demons, and
as the indices being accessed in the array are trivially calculable,
it's rash to invite gcc to do take any liberties at all.
Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
It's undefined behaviour in C to write outside the bounds of an array.
The key expansion routine takes a shortcut of creating 8 words at a
time, but this creates 4 additional words which don't fit in the array.
As everyone is hopefully now aware, GCC is at liberty to make any
assumptions and optimisations it likes in situations where it can
detect that UB has occured, up to and including nasal demons, and
as the indices being accessed in the array are trivially calculable,
it's rash to invite gcc to do take any liberties at all.
Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| crypto/aes_generic.c | diffblobblamehistory |