From 77d88312763af9aba8f25bbefe6a4852ff7f5447 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Sat, 6 Mar 2010 13:16:55 +0000
Subject: [PATCH] bug #2931429 Editing long triggers

---
 ChangeLog                      | 1 +
 libraries/common.lib.php       | 8 ++++----
 libraries/tbl_triggers.lib.php | 2 +-
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 457c495af6..fdd23ba28f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -15,6 +15,7 @@ $HeadURL: https://phpmyadmin.svn.sourceforge.net/svnroot/phpmyadmin/trunk/phpMyA
 - patch #2961540 [export] Do not export data of MERGE table,
   thanks to Dieter Adriaenssens - ruleant
 - bug #2961198 [parser] Querying a table named "data"
+- bug #2931429 [structure] Editing long triggers
 
 3.3.0.0 (not yet released)
 + rfe #2308632 [edit] Use hex for (var)binary fields,
diff --git a/libraries/common.lib.php b/libraries/common.lib.php
index 5d1193c80c..522a2242b4 100644
--- a/libraries/common.lib.php
+++ b/libraries/common.lib.php
@@ -1764,14 +1764,14 @@ function PMA_linkOrButton($url, $message, $tag_params = array(),
                     . implode(' ', $tag_params_strings)
                     . ' value="' . htmlspecialchars($message) . '" />';
             } else {
+                $displayed_message = htmlspecialchars(
+                        preg_replace('/^.*\salt="([^"]*)".*$/si', '\1',
+                            $message));
                 $ret .= '<input type="image"' . $submit_name . ' '
                     . implode(' ', $tag_params_strings)
                     . ' src="' . preg_replace(
                         '/^.*\ssrc="([^"]*)".*$/si', '\1', $message) . '"'
-                    . ' value="' . htmlspecialchars(
-                        preg_replace('/^.*\salt="([^"]*)".*$/si', '\1',
-                            $message))
-                    . '" />';
+                    . ' value="' . $displayed_message . '" title="' . $displayed_message . '" />'; 
             }
         } else {
             $message = trim(strip_tags($message));
diff --git a/libraries/tbl_triggers.lib.php b/libraries/tbl_triggers.lib.php
index 3055688cd9..92ad582733 100644
--- a/libraries/tbl_triggers.lib.php
+++ b/libraries/tbl_triggers.lib.php
@@ -41,7 +41,7 @@ if ($triggers) {
                          </tr>',
                          ($ct%2 == 0) ? 'even' : 'odd',
                          $trigger['name'],
-                         '<a href="tbl_sql.php?' . $url_query . '&amp;sql_query=' . urlencode($drop_and_create) . '&amp;show_query=1&amp;delimiter=' . urlencode($delimiter) . '">' . $titles['Change'] . '</a>',
+                         PMA_linkOrButton('tbl_sql.php?' . $url_query . '&amp;sql_query=' . urlencode($drop_and_create) . '&amp;show_query=1&amp;delimiter=' . urlencode($delimiter), $titles['Change']),
                          '<a href="sql.php?' . $url_query . '&sql_query=' . urlencode($trigger['drop']) . '" onclick="return confirmLink(this, \'' . PMA_jsFormat($trigger['drop'], false) . '\')">' . $titles['Drop'] . '</a>',
                          $trigger['action_timing'],
                          $trigger['event_manipulation']);
-- 
2.11.4.GIT