Clean up of tests (#19067)

Clean up of tests (#19067)

* Fix wrong type hint

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use $this instead of parent

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* setUp should be a protected method

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* onNotSuccessfulTest should be protected

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* $command doesn't need to be a property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Give alertText() proper return type

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use null-safe operator

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Call Message static constructors statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Call StorageEngine methods statically

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Add better type hints in PrivilegesController

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use packed (without keys) arrays in tests

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use type casts instead of function casts

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use const instead of private property

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Fix testAuthFailsTooLongPass()

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Replace loop with array_shift

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use ob_get_clean

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Remove duplicated code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
* Use assert instead of phpdoc

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---------

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>