Simplify gis polygon handling (#17904)
commit5116b0f0fe0ae6988123b02753b3d998e510d864
authorMoonE <maxi_kroeg@web.de>
Sat, 10 Dec 2022 18:09:40 +0000 (10 19:09 +0100)
committerGitHub <noreply@github.com>
Sat, 10 Dec 2022 18:09:40 +0000 (10 15:09 -0300)
tree06f8a227dcbe3032b831eff4e9a2b7da879dccd0
parent283d427cd9bf140d067184b15061d5d022979b2c
Simplify gis polygon handling (#17904)

* 'Expected' is first param for assertEquals

* Do direct string comparisons with gis svg test

Ids are not random during tests.

* Test gis png and pdf output

* Add pdf for i386 architecter, points are slightly different

* No special handling for inner and outer rings

Signed-off-by: Maximilian Krög <maxi_kroeg@web.de>
29 files changed:
libraries/classes/Gis/GisMultiPolygon.php
libraries/classes/Gis/GisPolygon.php
phpstan-baseline.neon
psalm-baseline.xml
test/classes/Gis/GisGeomTestCase.php
test/classes/Gis/GisGeometryCollectionTest.php
test/classes/Gis/GisLineStringTest.php
test/classes/Gis/GisMultiLineStringTest.php
test/classes/Gis/GisMultiPointTest.php
test/classes/Gis/GisMultiPolygonTest.php
test/classes/Gis/GisPointTest.php
test/classes/Gis/GisPolygonTest.php
test/test_data/gis/.gitignore [new file with mode: 0644]
test/test_data/gis/geometrycollection-expected.pdf [new file with mode: 0644]
test/test_data/gis/geometrycollection-expected.png [new file with mode: 0644]
test/test_data/gis/linestring-expected.pdf [new file with mode: 0644]
test/test_data/gis/linestring-expected.png [new file with mode: 0644]
test/test_data/gis/multilinestring-expected.pdf [new file with mode: 0644]
test/test_data/gis/multilinestring-expected.png [new file with mode: 0644]
test/test_data/gis/multipoint-expected-x86.pdf [new file with mode: 0644]
test/test_data/gis/multipoint-expected.pdf [new file with mode: 0644]
test/test_data/gis/multipoint-expected.png [new file with mode: 0644]
test/test_data/gis/multipolygon-expected.pdf [new file with mode: 0644]
test/test_data/gis/multipolygon-expected.png [new file with mode: 0644]
test/test_data/gis/point-expected-x86.pdf [new file with mode: 0644]
test/test_data/gis/point-expected.pdf [new file with mode: 0644]
test/test_data/gis/point-expected.png [new file with mode: 0644]
test/test_data/gis/polygon-expected.pdf [new file with mode: 0644]
test/test_data/gis/polygon-expected.png [new file with mode: 0644]