Addressing some PHP 8 incompatibilities - Remarkup
commitec9ebe532e521e9eb9cb2f6d11e97045e35fb368
authorChristopher Speck <die.drachen@gmail.com>
Wed, 24 May 2023 17:36:52 +0000 (24 13:36 -0400)
committerChristopher Speck <die.drachen@gmail.com>
Mon, 29 May 2023 03:11:56 +0000 (28 23:11 -0400)
treeedf249f328821b8593dbf232fb0522e753d96a67
parentce3d484b0ec7c59f72aad93c7cf5bea81d7757d7
Addressing some PHP 8 incompatibilities - Remarkup

Summary:
Updating compatibility for PHP 8.2 for remarkup-related functionality.

This also resolves an issue introduced by https://secure.phabricator.com/D21860. Of all the flags when opening the zip the one I chose was not introduced in 5.2 but in 7.4

Test Plan: I rendered comments using figlet, cowsay, images, object references.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D21866
.editorconfig
externals/pear-figlet/Text/Figlet.php
src/infrastructure/markup/interpreter/PhabricatorRemarkupCowsayBlockInterpreter.php
src/infrastructure/markup/interpreter/PhabricatorRemarkupFigletBlockInterpreter.php
src/infrastructure/markup/remarkup/PhutilRemarkupEngine.php