pg_upgrade: run all data type checks per connection
commit347758b1206364e3bec5ad6cd649b4ba9fe1be7b
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 19 Mar 2024 12:32:50 +0000 (19 13:32 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Tue, 19 Mar 2024 12:32:50 +0000 (19 13:32 +0100)
treecd5dbdc7d8f9257a7c64e6930b34e4df00dde152
parent5577a71fb0cc16bb7f5e3c40b89eb77460eac724
pg_upgrade: run all data type checks per connection

The checks for data type usage were each connecting to all databases
in the cluster and running their query. On clusters which have a lot
of databases this can become unnecessarily expensive. This moves the
checks to run in a single connection instead to minimize setup and
teardown overhead.

Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Reviewed-by: Peter Eisentraut <peter@eisentraut.org>
Discussion: https://postgr.es/m/BB4C76F-D416-4F9F-949E-DBE950D37787@yesql.se
src/bin/pg_upgrade/check.c
src/bin/pg_upgrade/pg_upgrade.h
src/bin/pg_upgrade/version.c