| commit | 12d768e70497afc5a57acf73c251316997b5175a | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 28 Feb 2022 17:54:12 +0000 (28 12:54 -0500) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 28 Feb 2022 17:54:12 +0000 (28 12:54 -0500) | ||
| tree | 129fc68a13e888875e85770beda5cddd6de775d7 | treesnapshot (tar.gz zip) |
| parent | 2e517818f4af4abe93bf56442469944544f10d4b | commitdiff |
Don't use static storage for SaveTransactionCharacteristics().
This is pretty queasy-making on general principles, and the more so
once you notice that CommitTransactionCommand() is actually stomping
on the values saved by _SPI_commit(). It's okay as long as the
active values didn't change during HoldPinnedPortals(); but that's
a larger assumption than I think we want to make, especially since
the fix is so simple.
Discussion: https://postgr.es/m/1533956.1645731245@sss.pgh.pa.us
This is pretty queasy-making on general principles, and the more so
once you notice that CommitTransactionCommand() is actually stomping
on the values saved by _SPI_commit(). It's okay as long as the
active values didn't change during HoldPinnedPortals(); but that's
a larger assumption than I think we want to make, especially since
the fix is so simple.
Discussion: https://postgr.es/m/1533956.1645731245@sss.pgh.pa.us
| src/backend/access/transam/xact.c | diffblobblamehistory | |
| src/backend/executor/spi.c | diffblobblamehistory | |
| src/include/access/xact.h | diffblobblamehistory |