| commit | f222349c4ec061705e121548d2fe646b4d03ccdf | |
| author | Noah Misch <noah@leadboat.com> | |
| Mon, 29 Apr 2024 17:24:56 +0000 (29 10:24 -0700) | ||
| committer | Noah Misch <noah@leadboat.com> | |
| Mon, 29 Apr 2024 17:25:00 +0000 (29 10:25 -0700) | ||
| tree | 4d58afb166cc2b74d54eefbcc11885d5e8838a85 | treesnapshot (tar.gz zip) |
| parent | cb0ccefa03d351d9c643362ac77fca7dadd9fc42 | commitdiff |
Close race condition between datfrozen and relfrozen updates.
vac_update_datfrozenxid() did multiple loads of relfrozenxid and
relminmxid from buffer memory, and it assumed each would get the same
value. Not so if a concurrent vac_update_relstats() did an inplace
update. Commit 2d2e40e3befd8b9e0d2757554537345b15fa6ea2 fixed the same
kind of bug in vac_truncate_clog(). Today's bug could cause the
rel-level field and XIDs in the rel's rows to precede the db-level
field. A cluster having such values should VACUUM affected tables.
Back-patch to v12 (all supported versions).
Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com
vac_update_datfrozenxid() did multiple loads of relfrozenxid and
relminmxid from buffer memory, and it assumed each would get the same
value. Not so if a concurrent vac_update_relstats() did an inplace
update. Commit 2d2e40e3befd8b9e0d2757554537345b15fa6ea2 fixed the same
kind of bug in vac_truncate_clog(). Today's bug could cause the
rel-level field and XIDs in the rel's rows to precede the db-level
field. A cluster having such values should VACUUM affected tables.
Back-patch to v12 (all supported versions).
Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com
| src/backend/commands/vacuum.c | diffblobblamehistory |