| commit | e6e50ada07bbbbea2a68597d0bf7f795b0dc1269 | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 18 Sep 2023 18:27:47 +0000 (18 14:27 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 18 Sep 2023 18:27:47 +0000 (18 14:27 -0400) | ||
| tree | 288aae6cffad64391ea74290aaa2574460b17669 | treesnapshot (tar.gz zip) |
| parent | c5b7f791dab95ca14122f7bc09cc729fcaf7e25c | commitdiff |
Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.
cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so. Add a defensive check.
It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor. Add some documentation to try to forestall future
errors of the same ilk.
Report and patch by Boyu Yang (docs changes by me). Back-patch
to all supported branches.
Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com
cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so. Add a defensive check.
It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor. Add some documentation to try to forestall future
errors of the same ilk.
Report and patch by Boyu Yang (docs changes by me). Back-patch
to all supported branches.
Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com
| doc/src/sgml/spi.sgml | diffblobblamehistory | |
| src/backend/utils/adt/xml.c | diffblobblamehistory |