| commit | cf807eba5dc4ea16721fa8562e38a41936ed600f | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Fri, 23 Feb 2024 20:21:53 +0000 (23 15:21 -0500) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Fri, 23 Feb 2024 20:21:53 +0000 (23 15:21 -0500) | ||
| tree | 2ee272e7fd71108b9066d390d75ee08c95d47d52 | treesnapshot (tar.gz zip) |
| parent | 3ffcd24c29c60e913c9f5f4c0911180c9f3b9897 | commitdiff |
Avoid dangling-pointer problem with partitionwise joins under GEQO.
build_child_join_sjinfo creates a derived SpecialJoinInfo in
the short-lived GEQO context, but afterwards the semi_rhs_exprs
from that may be used in a UniquePath for a child base relation.
This breaks the expectation that all base-relation-level structures
are in the planning-lifespan context, leading to use of a dangling
pointer with probable ensuing crash later on in create_unique_plan.
To fix, copy the expression trees when making a UniquePath.
Per bug #18360 from Alexander Lakhin. This has been broken since
partitionwise joins were added, so back-patch to all supported
branches.
Discussion: https://postgr.es/m/18360-a23caf3157f34e62@postgresql.org
build_child_join_sjinfo creates a derived SpecialJoinInfo in
the short-lived GEQO context, but afterwards the semi_rhs_exprs
from that may be used in a UniquePath for a child base relation.
This breaks the expectation that all base-relation-level structures
are in the planning-lifespan context, leading to use of a dangling
pointer with probable ensuing crash later on in create_unique_plan.
To fix, copy the expression trees when making a UniquePath.
Per bug #18360 from Alexander Lakhin. This has been broken since
partitionwise joins were added, so back-patch to all supported
branches.
Discussion: https://postgr.es/m/18360-a23caf3157f34e62@postgresql.org
| src/backend/optimizer/util/pathnode.c | diffblobblamehistory |