| commit | c8b881d21fd8e0214bc43280d6231cc2c6ef55ef | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 11 May 2023 17:44:25 +0000 (11 13:44 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 11 May 2023 17:44:25 +0000 (11 13:44 -0400) | ||
| tree | bd6fec7e5949d37acefb6f00c6337a1420b78cd1 | treesnapshot (tar.gz zip) |
| parent | 375407f4940ba0922513666f00852c54943eb1a0 | commitdiff |
Undo faulty attempt at not relying on RINFO_IS_PUSHED_DOWN.
I've had a bee in my bonnet for some time about getting rid of
RestrictInfo.is_pushed_down, because it's squishily defined and
requires not-inexpensive extra tests to use (cf RINFO_IS_PUSHED_DOWN).
In commit 2489d76c4, I tried to make remove_rel_from_query() not
depend on that macro; but the replacement test is buggy,
as exposed by a report from Rushabh Lathia and Robert Haas.
That change was pretty incidental to the main goal of 2489d76c4,
so let's just revert it for now. (Getting rid of is_pushed_down
is still far away, anyway.)
Discussion: https://postgr.es/m/CA+TgmoYco=hmg+iX1CW9Y1_CzNoSL81J03wUG-d2_3=rue+L2A@mail.gmail.com
I've had a bee in my bonnet for some time about getting rid of
RestrictInfo.is_pushed_down, because it's squishily defined and
requires not-inexpensive extra tests to use (cf RINFO_IS_PUSHED_DOWN).
In commit 2489d76c4, I tried to make remove_rel_from_query() not
depend on that macro; but the replacement test is buggy,
as exposed by a report from Rushabh Lathia and Robert Haas.
That change was pretty incidental to the main goal of 2489d76c4,
so let's just revert it for now. (Getting rid of is_pushed_down
is still far away, anyway.)
Discussion: https://postgr.es/m/CA+TgmoYco=hmg+iX1CW9Y1_CzNoSL81J03wUG-d2_3=rue+L2A@mail.gmail.com
| src/backend/optimizer/plan/analyzejoins.c | diffblobblamehistory | |
| src/test/regress/expected/join.out | diffblobblamehistory | |
| src/test/regress/sql/join.sql | diffblobblamehistory |