| commit | c21d4c416ad61b78cf450f11861bbafbdfb7eebc | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 8 Apr 2024 19:49:10 +0000 (8 15:49 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Mon, 8 Apr 2024 19:49:10 +0000 (8 15:49 -0400) | ||
| tree | 7b9f562a8c170fe2a5e75fd8c7753b9adf3887b4 | treesnapshot (tar.gz zip) |
| parent | 0fe5f64367bc2fc70baa1f0f993638830f8aa6a5 | commitdiff |
Further review for re-implementation of psql's FETCH_COUNT feature.
Alexander Lakhin noted an obsolete comment, which led me to revisit
some other important comments in the patch, and that study turned up a
couple of unintended ways in which the chunked-fetch code path didn't
match the normal code path in ExecQueryAndProcessResults. The only
nontrivial problem is that it didn't call PrintQueryStatus, so that
we'd not print the final status result from DML ... RETURNING
commands. To avoid code duplication, move the filter for whether a
result is from RETURNING from PrintQueryResult to PrintQueryStatus.
Discussion: https://postgr.es/m/0023bea5-79c0-476e-96c8-dad599cc3ad8@gmail.com
Alexander Lakhin noted an obsolete comment, which led me to revisit
some other important comments in the patch, and that study turned up a
couple of unintended ways in which the chunked-fetch code path didn't
match the normal code path in ExecQueryAndProcessResults. The only
nontrivial problem is that it didn't call PrintQueryStatus, so that
we'd not print the final status result from DML ... RETURNING
commands. To avoid code duplication, move the filter for whether a
result is from RETURNING from PrintQueryResult to PrintQueryStatus.
Discussion: https://postgr.es/m/0023bea5-79c0-476e-96c8-dad599cc3ad8@gmail.com
| src/bin/psql/common.c | diffblobblamehistory |