| commit | 9543eff5e015b6f6f832da2d95d659629a2022f3 | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 6 Oct 2022 17:35:31 +0000 (6 13:35 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 6 Oct 2022 17:35:31 +0000 (6 13:35 -0400) | ||
| tree | b5c27a4eaa8720dbf932ec3409df1cb9e1e62b07 | treesnapshot (tar.gz zip) |
| parent | 42b746d4c982257bf3f924176632b04dc288174b | commitdiff |
Remove MemoryContextContains().
MemoryContextContains is no longer reliable in the wake of c6e0fe1f2,
because there's no longer very much redundancy in chunk headers.
(It wasn't *completely* reliable even before that, as there was a
chance of a false positive if you passed it something that didn't
point to an mcxt chunk at all. But it was generally good enough.)
Hence, remove it. There is no remaining core code that requires it.
Extensions that have been using it might be able to substitute a
test like "GetMemoryChunkContext(ptr) == context", recognizing that
this explicitly requires that the pointer point to some chunk.
Tom Lane and David Rowley
Discussion: https://postgr.es/m/1913788.1664898906@sss.pgh.pa.us
MemoryContextContains is no longer reliable in the wake of c6e0fe1f2,
because there's no longer very much redundancy in chunk headers.
(It wasn't *completely* reliable even before that, as there was a
chance of a false positive if you passed it something that didn't
point to an mcxt chunk at all. But it was generally good enough.)
Hence, remove it. There is no remaining core code that requires it.
Extensions that have been using it might be able to substitute a
test like "GetMemoryChunkContext(ptr) == context", recognizing that
this explicitly requires that the pointer point to some chunk.
Tom Lane and David Rowley
Discussion: https://postgr.es/m/1913788.1664898906@sss.pgh.pa.us
| src/backend/utils/mmgr/mcxt.c | diffblobblamehistory | |
| src/include/utils/memutils.h | diffblobblamehistory |