Fix assorted resource leaks in new pg_createsubscriber code.
commit91cbb4b492cbea889e8392a85e246c1778ca2a45
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Apr 2024 17:47:27 +0000 (1 13:47 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Apr 2024 17:47:49 +0000 (1 13:47 -0400)
treeba650f890085c07867403513408c8bfda2ca887c
parent6f47f6883151366c031cd6fd4011e66d2c702a90
Fix assorted resource leaks in new pg_createsubscriber code.

Various error paths did not release resources before returning.
While it's likely that the program would just exit shortly later,
none of the functions in question have summary exit(1) calls,
so they should not be assuming that.

Ranier Vilela and Tom Lane, per reports from Coverity

Discussion: https://postgr.es/m/CAEudQAr2_SZFxB4kXJiL4+2UaNZxUk5UBJtj0oXyJYMGZu-03g@mail.gmail.com
src/bin/pg_basebackup/pg_createsubscriber.c