| commit | 8b2e9fd26afd9f379ea8bedeb4b11a354c09a3e1 | |
| author | Richard Guo <rguo@postgresql.org> | |
| Tue, 23 Jul 2024 02:18:53 +0000 (23 11:18 +0900) | ||
| committer | Richard Guo <rguo@postgresql.org> | |
| Tue, 23 Jul 2024 02:18:53 +0000 (23 11:18 +0900) | ||
| tree | 8733dd6eb6cf0ad304b88fcd305658a5af4d1720 | treesnapshot (tar.gz zip) |
| parent | 581df2148737fdb0ba6f2d8fda5ceb9d1e6302e6 | commitdiff |
Remove redundant code in create_gather_merge_path
In create_gather_merge_path, we should always guarantee that the
subpath is adequately ordered, and we do not add a Sort node in
createplan.c for a Gather Merge node. Therefore, the 'else' branch in
create_gather_merge_path, which computes the cost for a Sort node, is
redundant.
This patch removes the redundant code and emits an error if the
subpath is not sufficiently ordered. Meanwhile, this patch changes
the check for the subpath's pathkeys in create_gather_merge_plan to an
Assert.
Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs48u=0bWf3epVtULjJ-=M9Hbkz+ieZQAOS=BfbXZFqbDCg@mail.gmail.com
In create_gather_merge_path, we should always guarantee that the
subpath is adequately ordered, and we do not add a Sort node in
createplan.c for a Gather Merge node. Therefore, the 'else' branch in
create_gather_merge_path, which computes the cost for a Sort node, is
redundant.
This patch removes the redundant code and emits an error if the
subpath is not sufficiently ordered. Meanwhile, this patch changes
the check for the subpath's pathkeys in create_gather_merge_plan to an
Assert.
Author: Richard Guo
Discussion: https://postgr.es/m/CAMbWs48u=0bWf3epVtULjJ-=M9Hbkz+ieZQAOS=BfbXZFqbDCg@mail.gmail.com
| src/backend/optimizer/plan/createplan.c | diffblobblamehistory | |
| src/backend/optimizer/util/pathnode.c | diffblobblamehistory |