| commit | 6c77bb42ab0eb3f79e934ed3c97568119cca7b5f | |
| author | Michael Paquier <michael@paquier.xyz> | |
| Mon, 2 Oct 2023 23:27:34 +0000 (3 08:27 +0900) | ||
| committer | Michael Paquier <michael@paquier.xyz> | |
| Mon, 2 Oct 2023 23:27:34 +0000 (3 08:27 +0900) | ||
| tree | 1e3fccf503e545cb5b9a9c2cd12c7452ee254af9 | treesnapshot (tar.gz zip) |
| parent | 06c0c36884a5c9ced6d6a90f8b47540464b28e3a | commitdiff |
Replace use of stat()[7] by -s switch in TAP tests to retrieve file size
The list form of stat() is an inelegant API as it relies on the position
of the file size in the list returned in result. Like in any other
places of the tree, replace that with a -s switch instead.
Another suggestion from Dagfinn is File::Stat, which we've been already
using for some other fields. It really comes down to a matter of taste
to choose that over -s, and the latter is more used in the tree.
Author: Bertrand Drouvot
Reviewed-by: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/b2020df7-d0fc-4ea5-b2a9-7efc6d36b2ac@gmail.com
The list form of stat() is an inelegant API as it relies on the position
of the file size in the list returned in result. Like in any other
places of the tree, replace that with a -s switch instead.
Another suggestion from Dagfinn is File::Stat, which we've been already
using for some other fields. It really comes down to a matter of taste
to choose that over -s, and the latter is more used in the tree.
Author: Bertrand Drouvot
Reviewed-by: Dagfinn Ilmari Mannsåker
Discussion: https://postgr.es/m/b2020df7-d0fc-4ea5-b2a9-7efc6d36b2ac@gmail.com
| src/bin/pg_controldata/t/001_pg_controldata.pl | diffblobblamehistory | |
| src/bin/pg_resetwal/t/002_corrupted.pl | diffblobblamehistory | |
| src/test/recovery/t/019_replslot_limit.pl | diffblobblamehistory |