Improve comments for trivial_subqueryscan().
commit4a8a5dd7f59cd8dd9969cef1969cb5f7c5124eec
authorEtsuro Fujita <efujita@postgresql.org>
Thu, 9 Jun 2022 10:30:00 +0000 (9 19:30 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Thu, 9 Jun 2022 10:30:00 +0000 (9 19:30 +0900)
treed4e69a83e9f13eb608f5a3b4b49a9079fd0cbf98
parente77de23fbb0f4ef27090c144edcfa889bb2a06d5
Improve comments for trivial_subqueryscan().

This function can be called from mark_async_capable_plan(), a helper
function for create_append_plan(), before set_subqueryscan_references(),
to determine the triviality of a SubqueryScan that is a child of an
Append plan node, which is done before doing finalize_plan() on the
SubqueryScan (if necessary) and set_plan_references() on the subplan,
unlike when called from set_subqueryscan_references().  The reason why
this is safe wouldn't be that obvious, so add comments explaining this.

Follow-up for commit c2bb02bc2.

Reviewed by Zhihong Yu.

Discussion: https://postgr.es/m/CAPmGK17%2BGiJBthC6va7%2B9n6t75e-M1N0U18YB2G1B%2BE5OdrNTA%40mail.gmail.com
src/backend/optimizer/plan/setrefs.c