pg_stat_statements: fetch stmt location/length before it disappears.
commit495e73c2079eb53fcfbafbe18b7dce81aeb271ec
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (1 12:48 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 1 Nov 2022 16:48:01 +0000 (1 12:48 -0400)
tree74e5c878e9a5a45380fdcfb9efaeae72c72f356b
parent84387fc889442bd92b5969aa314b85cff360c7fe
pg_stat_statements: fetch stmt location/length before it disappears.

When executing a utility statement, we must fetch everything
we need out of the PlannedStmt data structure before calling
standard_ProcessUtility.  In certain cases (possibly only ROLLBACK
in extended query protocol), that data structure will get freed
during command execution.  The situation is probably often harmless
in production builds, but in debug builds we intentionally overwrite
the freed memory with garbage, leading to picking up garbage values
of statement location and length, typically causing an assertion
failure later in pg_stat_statements.  In non-debug builds, if
something did go wrong it would likely lead to storing garbage
for the query string.

Report and fix by zhaoqigui (with cosmetic adjustments by me).
It's an old problem, so back-patch to all supported versions.

Discussion: https://postgr.es/m/17663-a344fd0675f92128@postgresql.org
Discussion: https://postgr.es/m/1667307420050.56657@hundsun.com
contrib/pg_stat_statements/pg_stat_statements.c