pg_upgrade: generate check error for left-over new tablespace
commit3c0471b5fdd847febb30ec805a3e44f3eac5b66f
authorBruce Momjian <bruce@momjian.us>
Thu, 15 Oct 2020 23:33:36 +0000 (15 19:33 -0400)
committerBruce Momjian <bruce@momjian.us>
Thu, 15 Oct 2020 23:33:46 +0000 (15 19:33 -0400)
tree1e63c813d0506b379b8ef3527ecece07abe51327
parent72559438f92f9a7d9205192bef601be953c7bd2a
pg_upgrade:  generate check error for left-over new tablespace

Previously, if pg_upgrade failed, and the user recreated the cluster but
did not remove the new cluster tablespace directory, a later pg_upgrade
would fail since the new tablespace directory would already exists.
This adds error reporting for this during check.

Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20200925005531.GJ23631@telsasoft.com

Backpatch-through: 9.5
src/bin/pg_upgrade/check.c