| commit | 0553528e7c2bb9eb4148ff9e3c51b9094ab67f70 | |
| author | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 4 May 2023 15:00:33 +0000 (4 11:00 -0400) | ||
| committer | Tom Lane <tgl@sss.pgh.pa.us> | |
| Thu, 4 May 2023 15:00:33 +0000 (4 11:00 -0400) | ||
| tree | d7c47784e3f17464fa9b319c0dcfbd3d1069512e | treesnapshot (tar.gz zip) |
| parent | 5472743d9e8583638a897b47558066167cc14583 | commitdiff |
Tighten array dimensionality checks in Python -> SQL array conversion.
Like plperl before f47004add, plpython wasn't being sufficiently
careful about checking that list-of-list structures represent
rectangular arrays, so that it would accept some cases in which
different parts of the "array" are nested to different depths.
This was exacerbated by Python's weak distinction between
sequences and lists, so that in some cases strings could get
treated as though they are lists (and burst into individual
characters) even though a different ordering of the upper-level
list would give a different result.
Some of this behavior was unreachable (without risking a crash)
before 81eaaf65e. It seems like a good idea to clean it all up
in the same releases, rather than shipping a non-crashing but
nonetheless visibly buggy behavior in the name of minimal change.
Hence, back-patch.
Per bug #17912 and further testing by Alexander Lakhin.
Discussion: https://postgr.es/m/17912-82ceed78731d9cdc@postgresql.org
Like plperl before f47004add, plpython wasn't being sufficiently
careful about checking that list-of-list structures represent
rectangular arrays, so that it would accept some cases in which
different parts of the "array" are nested to different depths.
This was exacerbated by Python's weak distinction between
sequences and lists, so that in some cases strings could get
treated as though they are lists (and burst into individual
characters) even though a different ordering of the upper-level
list would give a different result.
Some of this behavior was unreachable (without risking a crash)
before 81eaaf65e. It seems like a good idea to clean it all up
in the same releases, rather than shipping a non-crashing but
nonetheless visibly buggy behavior in the name of minimal change.
Hence, back-patch.
Per bug #17912 and further testing by Alexander Lakhin.
Discussion: https://postgr.es/m/17912-82ceed78731d9cdc@postgresql.org
| src/pl/plpython/expected/plpython_types.out | diffblobblamehistory | |
| src/pl/plpython/plpy_typeio.c | diffblobblamehistory | |
| src/pl/plpython/sql/plpython_types.sql | diffblobblamehistory |