Ensure handle is valid and pm_errno is reset when calling into API
commitee015f086f3c40390659bbc0129b7c08ffd0ed5f
authorDan McGee <dan@archlinux.org>
Tue, 14 Jun 2011 15:01:08 +0000 (14 10:01 -0500)
committerDan McGee <dan@archlinux.org>
Tue, 14 Jun 2011 15:01:08 +0000 (14 10:01 -0500)
treeb2ba33041450fd5c5fb226649b88534fdac60ff1
parentbe972767358e6dfbb08686555d8e2c0176a55106
Ensure handle is valid and pm_errno is reset when calling into API

We didn't do due diligence before and ensure prior pm_errno values
weren't influencing what happened in further ALPM calls. I observed one
case of early setup code setting pm_errno to PM_ERR_WRONG_ARGS and that
flag persisting the entire time we were calling library code.

Add a new CHECK_HANDLE() macro that does two things: 1) ensures the
handle variable passed to it is non-NULL and 2) clears any existing
pm_errno flag set on the handle. This macro can replace many places we
used the ASSERT(handle != NULL, ...) pattern before.

Several other other places only need a simple 'set to zero' of the
pm_errno field.

Signed-off-by: Dan McGee <dan@archlinux.org>
15 files changed:
lib/libalpm/add.c
lib/libalpm/alpm.c
lib/libalpm/be_package.c
lib/libalpm/be_sync.c
lib/libalpm/conflict.c
lib/libalpm/db.c
lib/libalpm/deps.c
lib/libalpm/dload.c
lib/libalpm/handle.c
lib/libalpm/package.c
lib/libalpm/remove.c
lib/libalpm/signing.c
lib/libalpm/sync.c
lib/libalpm/trans.c
lib/libalpm/util.h