Remove trans->targets
commitd060e31be3586ce27382f80eaed7a9edf2c86aeb
authorNagy Gabor <ngaba@bibl.u-szeged.hu>
Mon, 10 Mar 2008 14:38:08 +0000 (10 15:38 +0100)
committerDan McGee <dan@archlinux.org>
Mon, 10 Mar 2008 23:57:36 +0000 (10 18:57 -0500)
tree2e7ded6300e22445e539a8ea913a9f296e0739eb
parentf56f7ff39102dab754573b0bc40dbceb5a8ec301
Remove trans->targets

Its implementation was quite broken:
* add_loadtarget() might have silently filtered out some targets when
  replacing an older version.
* This was used in sync.c to determine whether a target is implicit or not,
  which is incorrect behavior. Before this patch we silently removed user
  confirmed replacements; now we always warn on a replacement.
* remove001.py behavior was quite odd in adding same target 5 times to the
  target list, we can change this behavior to be a failure.

Signed-off-by: Nagy Gabor <ngaba@bibl.u-szeged.hu>
[Xav: changed remove001 pactest accordingly]
Signed-off-by: Chantry Xavier <shiningxc@gmail.com>
[Dan: rewrote commit message]
Signed-off-by: Dan McGee <dan@archlinux.org>
lib/libalpm/add.c
lib/libalpm/alpm.h
lib/libalpm/sync.c
lib/libalpm/trans.c
lib/libalpm/trans.h
pactest/tests/remove001.py