| commit | 06cbb516c35eb81220064878ff202c3107b12c99 | |
| author | Dan McGee <dan@archlinux.org> | |
| Wed, 9 Feb 2011 03:16:36 +0000 (8 21:16 -0600) | ||
| committer | Dan McGee <dan@archlinux.org> | |
| Fri, 11 Feb 2011 16:23:43 +0000 (11 10:23 -0600) | ||
| tree | ea0caedb4afbb01b3ad3ade7f140d55826433247 | treesnapshot (tar.gz zip) |
| parent | 56721c12cec02366816130aafaa974667db59a93 | commitdiff |
Avoid a memmove by advancing value pointer
In packages, our description file contains:
key = value is here
type entries, and we passed "key " and " value is here" to our strtrim
function, causing us to always memmove the value portion to remove the
space. Since this is a throwaway buffer, do the advancing on our own before
trimming to save the need to shift memory around; "value is here" will now
be passed and strtrim will be responsible for trailing whitespace.
Signed-off-by: Dan McGee <dan@archlinux.org>
In packages, our description file contains:
key = value is here
type entries, and we passed "key " and " value is here" to our strtrim
function, causing us to always memmove the value portion to remove the
space. Since this is a throwaway buffer, do the advancing on our own before
trimming to save the need to shift memory around; "value is here" will now
be passed and strtrim will be responsible for trailing whitespace.
Signed-off-by: Dan McGee <dan@archlinux.org>
| lib/libalpm/be_package.c | diffblobblamehistory |