From ee54f7e9f0ad096d8db91a302c70d18d250db74b Mon Sep 17 00:00:00 2001 From: Paul Fertser Date: Mon, 7 Apr 2014 12:33:53 +0400 Subject: [PATCH] target/cortex_a: check gdb_service before dereferencing in update_halt_gdb If gdb was disconnected by the moment the target entered halted state, update_halt_gdb would segfault. Change-Id: I67477e9199c1df097be83a49e38602f975c083f5 Reported-by: Younes REGAIEG Signed-off-by: Paul Fertser Reviewed-on: http://openocd.zylin.com/2098 Tested-by: jenkins Reviewed-by: Spencer Oliver --- src/target/cortex_a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/target/cortex_a.c b/src/target/cortex_a.c index e95297cbe..50eb9d48a 100644 --- a/src/target/cortex_a.c +++ b/src/target/cortex_a.c @@ -766,7 +766,7 @@ static int cortex_a8_halt_smp(struct target *target) static int update_halt_gdb(struct target *target) { int retval = 0; - if (target->gdb_service->core[0] == -1) { + if (target->gdb_service && target->gdb_service->core[0] == -1) { target->gdb_service->target = target; target->gdb_service->core[0] = target->coreid; retval += cortex_a8_halt_smp(target); -- 2.11.4.GIT