rtos: hwthread: fix clang error core.NullDereference
commitfb23c9c10bd161ac05b85e73ad91676063592b96
authorAntonio Borneo <borneo.antonio@gmail.com>
Thu, 3 Nov 2022 23:32:20 +0000 (4 00:32 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 11 Nov 2022 20:23:13 +0000 (11 20:23 +0000)
treed4d184ce54ee2cbb6d1aa2b484de16b902489045
parent09731b69a6f50c7e0e2f6fa0ba245374034217cb
rtos: hwthread: fix clang error core.NullDereference

Clang spots a potential NULL pointer dereferencing that is instead
an incorrect use of an array of pointers:

src/rtos/hwthread.c:254:32: warning: Dereference of null pointer
  [core.NullDereference]
(*rtos_reg_list)[j].number = (*reg_list)[i].number;
                             ^~~~~~~~~~~~~~~~~~~~~
The error has not been spotted before because:
- this function is not called for the first core of the SMP node,
- for the other cores on Cortex-A it still returns valid register
  value for the first 12 ARM registers, then it diverges.

Also Valgrind does not spot any issue at runtime.

Address the array correctly.

While there, use DIV_ROUND_UP() macro for the computation.

Change-Id: Ib87e60e0edfd9671091f5dcfa9aedaf1aed800d1
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7337
Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>
src/rtos/hwthread.c