| commit | a6b02219529d1d48d130e4bed9c8d55395662ff6 | |
| author | Antonio Borneo <borneo.antonio@gmail.com> | |
| Sat, 10 Dec 2022 21:15:44 +0000 (10 22:15 +0100) | ||
| committer | Antonio Borneo <borneo.antonio@gmail.com> | |
| Sat, 17 Dec 2022 09:31:29 +0000 (17 09:31 +0000) | ||
| tree | 25d2d541b11ba6f52cc315cc968a1bf4e8b2ac9b | treesnapshot (tar.gz zip) |
| parent | c6fe10de75763623dfdaaf2fe3fff7e78a4ca146 | commitdiff |
target: cortex_a: fix clang error core.CallAndMessage
Clang complains about the variable 'orig_dfsr' that can be used
uninitialized both in cortex_a_read_cpu_memory() and in
cortex_a_write_cpu_memory().
The issue is caused by an incorrect error path that used to jump
through 'goto out'. The code after the label 'out' is specific to
handle the case of an error during memory R/W; it is incorrect to
jump there to handle an error during the initialization that
precedes the memory R/W.
Replace the 'goto out' with 'return retval'.
Remove the label 'out' that is now unused.
Change-Id: Ib4b140221d1c1b63419de109579bde8b63fc2e8c
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7393
Tested-by: jenkins
Clang complains about the variable 'orig_dfsr' that can be used
uninitialized both in cortex_a_read_cpu_memory() and in
cortex_a_write_cpu_memory().
The issue is caused by an incorrect error path that used to jump
through 'goto out'. The code after the label 'out' is specific to
handle the case of an error during memory R/W; it is incorrect to
jump there to handle an error during the initialization that
precedes the memory R/W.
Replace the 'goto out' with 'return retval'.
Remove the label 'out' that is now unused.
Change-Id: Ib4b140221d1c1b63419de109579bde8b63fc2e8c
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7393
Tested-by: jenkins
| src/target/cortex_a.c | diffblobblamehistory |