target: arc: rewrite command 'arc add-reg-type-struct' as COMMAND_HANDLER
commit85f3b10a6914fd44c8f32d345654bed371d0667d
authorAntonio Borneo <borneo.antonio@gmail.com>
Mon, 26 Dec 2022 23:56:55 +0000 (27 00:56 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 3 Feb 2023 22:48:26 +0000 (3 22:48 +0000)
tree19ff69f2a53bde8d7d5797ca1e986a50d9cc6985
parent92ef27494c510a2df7cbbee8b19d5c0d4d943d40
target: arc: rewrite command 'arc add-reg-type-struct' as COMMAND_HANDLER

Use a COMMAND_HELPER() to avoid memory leaks when the helper
COMMAND_PARSE_NUMBER() returns due to an error.

While there:
- fix potential SIGSEGV due to dereference 'type' before checking
  it's not NULL;
- fix an incorrect NUL byte termination while copying to
  type->data_type.id and to bitfields[cur_field].name;
- fix some coding style error;
- remove the now unused function jim_arc_read_reg_type_field().

Change-Id: I7158fd93b5d4742f11654b8ae4a7abd409ad06e2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7425
Tested-by: jenkins
Reviewed-by: Evgeniy Didin <didin@synopsys.com>
src/target/arc_cmd.c