| commit | 7a3eec2b4d9dbb9533acfb271dbe91afa0727c8e | |
| author | Tomas Vanek <vanekt@fbl.cz> | |
| Tue, 18 Dec 2018 16:17:33 +0000 (18 17:17 +0100) | ||
| committer | Matthias Welwarsky <matthias@welwarsky.de> | |
| Thu, 7 Feb 2019 07:51:50 +0000 (7 07:51 +0000) | ||
| tree | 8b8d19f57f6f12dec1c1c0b728f04f1c6309bbbf | treesnapshot (tar.gz zip) |
| parent | 0d48104e03320112db1e8825d0700ea8be735cef | commitdiff |
target algo: do not write reg_param if direction is PARAM_IN
Without this change xxx_start_algorithm() writes all register
parameters no matter of their direction. It usually results
in writing of uninitialized reg_params[].value - possibly
reported by valgrind.
While on it fix the wrong parameter direction in
kinetis_disable_wdog_algo(). This bug did not have any
impact because of unconditional write of reg_params.
Change-Id: Ia9c6a7b37f77d5eb6e5f5463012dddd50471742b
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4813
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>
Without this change xxx_start_algorithm() writes all register
parameters no matter of their direction. It usually results
in writing of uninitialized reg_params[].value - possibly
reported by valgrind.
While on it fix the wrong parameter direction in
kinetis_disable_wdog_algo(). This bug did not have any
impact because of unconditional write of reg_params.
Change-Id: Ia9c6a7b37f77d5eb6e5f5463012dddd50471742b
Signed-off-by: Tomas Vanek <vanekt@fbl.cz>
Reviewed-on: http://openocd.zylin.com/4813
Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Matthias Welwarsky <matthias@welwarsky.de>