dsp5680xx: fix clang error core.UndefinedBinaryOperatorResult
commit5fc4882b8039dbd35f2efcd1419e83fbda9eba28
authorAntonio Borneo <borneo.antonio@gmail.com>
Wed, 2 Nov 2022 00:13:49 +0000 (2 01:13 +0100)
committerAntonio Borneo <borneo.antonio@gmail.com>
Fri, 11 Nov 2022 20:11:22 +0000 (11 20:11 +0000)
tree6aa96ccc8f8225593e5df39b9b2108e35c20b744
parent0946e80407150b68acd02bc59f0f3a3170142c4c
dsp5680xx: fix clang error core.UndefinedBinaryOperatorResult

Clang get confused by initializing the array uint16_t lock_word[],
casting it to (uint8_t *), then accessing the second element of
the uint8_t pointer.

  src/target/dsp5680xx.c:2046:41: warning: The left operand of '<<'
    is a garbage value [core.UndefinedBinaryOperatorResult]
        uint16_t tmp = (buffer[0] | (buffer[1] << 8));
                                     ~~~~~~~~~ ^
Fix it by replacing the array with a single uint16_t.

The code is still depending on host endianness; no fix for this is
proposed.

Change-Id: I16dfd60cab117dd145aeecf10d9593574ff233a2
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: https://review.openocd.org/c/openocd/+/7302
Tested-by: jenkins
src/target/dsp5680xx.c