From 084d17b3ade4ca326e709bc112b0c78578674a99 Mon Sep 17 00:00:00 2001
From: stephen waite <stephen.waite@cmsvt.com>
Date: Thu, 9 Nov 2023 08:35:27 -0500
Subject: [PATCH] fix: use btn-link instead of a link for dashboard cards
 (#6995)

* fix: use btn-link instead of a tag for dashboard cards

* remove redundant section classes card mb-2

* change listening element to button
---
 interface/patient_file/summary/demographics.php | 2 +-
 templates/patient/card/card_base.html.twig      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/interface/patient_file/summary/demographics.php b/interface/patient_file/summary/demographics.php
index 63078acd0..56b33f772 100644
--- a/interface/patient_file/summary/demographics.php
+++ b/interface/patient_file/summary/demographics.php
@@ -853,7 +853,7 @@ $oemr_ui = new OemrUI($arrOeUiSettings);
 
         // Update the User's visibility setting when the card header is clicked
         function cardTitleButtonClickListener() {
-            const buttons = document.querySelectorAll(".card-title a[data-toggle='collapse']");
+            const buttons = document.querySelectorAll(".card-title button[data-toggle='collapse']");
             buttons.forEach((b) => {
                 b.addEventListener("click", (e) => {
                     updateUserVisibilitySetting(e);
diff --git a/templates/patient/card/card_base.html.twig b/templates/patient/card/card_base.html.twig
index b3db281b7..9668dcdd5 100644
--- a/templates/patient/card/card_base.html.twig
+++ b/templates/patient/card/card_base.html.twig
@@ -1,7 +1,7 @@
-<section class="{{ card_container_class_list|default(['card', 'mb-2'])|join(' ') }} card mb-2 {{ card_bg_color }} {{ card_text_color }}">
+<section class="{{ card_container_class_list|default(['card', 'mb-2'])|join(' ') }} {{ card_bg_color }} {{ card_text_color }}">
     <div class="card-body p-1">
         <h6 class="card-title mb-0 d-flex p-1 justify-content-between">
-            <a class="text-left font-weight-bolder" href="#" {% if forceAlwaysOpen != true %}data-toggle="collapse" data-target="#{{ id|attr }}"{% endif %} aria-expanded="true" aria-controls="{{ id|attr }}">{{ title|text }}<i class="ml-1 fa fa-fw fa-sm fa-expand">&nbsp;</i></a>
+            <button class="btn btn-sm btn-link" href="#" {% if forceAlwaysOpen != true %} data-toggle="collapse" data-target="#{{ id|attr }}" {% endif %} aria-expanded="true" aria-controls="{{ id|attr }}">{{ title|text }}</button>
             {% if auth %}
                 <span>
                 {% if card.canAdd() or btnLabel == "Add" %}
-- 
2.11.4.GIT