From b2d33090f5c98fd727c577903a82869b8658d8b9 Mon Sep 17 00:00:00 2001 From: jakub Date: Wed, 25 Aug 2010 09:36:35 +0000 Subject: [PATCH] PR tree-optimization/45059 * tree-ssa-reassoc.c (eliminate_redundant_comparison): Strip useless type conversions from newop{1,2}. Assert t is a comparison and newop{1,2} after the stripping are gimple vals. * gcc.c-torture/compile/pr45059.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@163539 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 7 +++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.c-torture/compile/pr45059.c | 23 +++++++++++++++++++++++ gcc/tree-ssa-reassoc.c | 5 +++++ 4 files changed, 40 insertions(+) create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr45059.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 29c5aecd4b2..28a831a515b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2010-08-25 Jakub Jelinek + + PR tree-optimization/45059 + * tree-ssa-reassoc.c (eliminate_redundant_comparison): Strip useless + type conversions from newop{1,2}. Assert t is a comparison and + newop{1,2} after the stripping are gimple vals. + 2010-08-25 Tejas Belagod * config/arm/iterators.md (VU, SE, V_widen_l): New. diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 7a92568cb70..db3ae97dfc1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-08-25 Jakub Jelinek + + PR tree-optimization/45059 + * gcc.c-torture/compile/pr45059.c: New test. + 2010-08-25 Tejas Belagod * lib/target-supports.exp (check_effective_target_vect_unpack): diff --git a/gcc/testsuite/gcc.c-torture/compile/pr45059.c b/gcc/testsuite/gcc.c-torture/compile/pr45059.c new file mode 100644 index 00000000000..3f13cdbf8c7 --- /dev/null +++ b/gcc/testsuite/gcc.c-torture/compile/pr45059.c @@ -0,0 +1,23 @@ +/* PR tree-optimization/45059 */ + +typedef unsigned int T; +extern void foo (signed char *, int); + +static signed char a; +static T b[1] = { -1 }; +static unsigned char c; + +static inline short int +bar (short v) +{ + c |= a < b[0]; + return 0; +} + +int +main () +{ + signed char *e = &a; + foo (e, bar (bar (c))); + return 0; +} diff --git a/gcc/tree-ssa-reassoc.c b/gcc/tree-ssa-reassoc.c index fd0a6d803d5..f2264b603c4 100644 --- a/gcc/tree-ssa-reassoc.c +++ b/gcc/tree-ssa-reassoc.c @@ -1314,9 +1314,14 @@ eliminate_redundant_comparison (enum tree_code opcode, enum tree_code subcode; tree newop1; tree newop2; + gcc_assert (COMPARISON_CLASS_P (t)); tmpvar = create_tmp_var (TREE_TYPE (t), NULL); add_referenced_var (tmpvar); extract_ops_from_tree (t, &subcode, &newop1, &newop2); + STRIP_USELESS_TYPE_CONVERSION (newop1); + STRIP_USELESS_TYPE_CONVERSION (newop2); + gcc_checking_assert (is_gimple_val (newop1) + && is_gimple_val (newop2)); sum = build_and_add_sum (tmpvar, newop1, newop2, subcode); curr->op = gimple_get_lhs (sum); } -- 2.11.4.GIT