From 9fead2aba033359563906d71090b06d708d6becf Mon Sep 17 00:00:00 2001 From: jakub Date: Fri, 10 Nov 2017 10:31:34 +0000 Subject: [PATCH] PR bootstrap/82916 * gimple-ssa-store-merging.c (pass_store_merging::terminate_all_aliasing_chains): For gimple_store_p stmts also call refs_output_dependent_p. * gcc.dg/store_merging_2.c: Only expect 2 successful mergings instead of 3. * gcc.dg/pr82916.c: New test. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@254623 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 5 ++++ gcc/gimple-ssa-store-merging.c | 7 +++-- gcc/testsuite/ChangeLog | 7 +++++ gcc/testsuite/gcc.dg/pr82916.c | 47 ++++++++++++++++++++++++++++++++++ gcc/testsuite/gcc.dg/store_merging_2.c | 2 +- 5 files changed, 65 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr82916.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f2de9142e6a..b82ce62fdff 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,10 @@ 2017-11-10 Jakub Jelinek + PR bootstrap/82916 + * gimple-ssa-store-merging.c + (pass_store_merging::terminate_all_aliasing_chains): For + gimple_store_p stmts also call refs_output_dependent_p. + PR rtl-optimization/82913 * compare-elim.c (try_merge_compare): Punt if def_insn is not single set. diff --git a/gcc/gimple-ssa-store-merging.c b/gcc/gimple-ssa-store-merging.c index 421498beafb..a5ee7aa3943 100644 --- a/gcc/gimple-ssa-store-merging.c +++ b/gcc/gimple-ssa-store-merging.c @@ -947,6 +947,7 @@ pass_store_merging::terminate_all_aliasing_chains (imm_store_chain_info if (!gimple_vuse (stmt)) return false; + tree store_lhs = gimple_store_p (stmt) ? gimple_get_lhs (stmt) : NULL_TREE; for (imm_store_chain_info *next = m_stores_head, *cur = next; cur; cur = next) { next = cur->next; @@ -960,8 +961,10 @@ pass_store_merging::terminate_all_aliasing_chains (imm_store_chain_info unsigned int i; FOR_EACH_VEC_ELT (cur->m_store_info, i, info) { - if (ref_maybe_used_by_stmt_p (stmt, gimple_assign_lhs (info->stmt)) - || stmt_may_clobber_ref_p (stmt, gimple_assign_lhs (info->stmt))) + tree lhs = gimple_assign_lhs (info->stmt); + if (ref_maybe_used_by_stmt_p (stmt, lhs) + || stmt_may_clobber_ref_p (stmt, lhs) + || (store_lhs && refs_output_dependent_p (store_lhs, lhs))) { if (dump_file && (dump_flags & TDF_DETAILS)) { diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index e83d3ce03db..a543e4fa404 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,10 @@ +2017-11-10 Jakub Jelinek + + PR bootstrap/82916 + * gcc.dg/store_merging_2.c: Only expect 2 successful mergings instead + of 3. + * gcc.dg/pr82916.c: New test. + 2017-11-10 Thomas Preud'homme * lib/scanasm.exp (scan-assembler): Extract filename from testname used diff --git a/gcc/testsuite/gcc.dg/pr82916.c b/gcc/testsuite/gcc.dg/pr82916.c new file mode 100644 index 00000000000..50e467f3244 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr82916.c @@ -0,0 +1,47 @@ +/* PR bootstrap/82916 */ +/* { dg-do run } */ +/* { dg-options "-O2 -fno-tree-dse" } */ + +struct A { struct A *next; }; +struct C +{ + int *of; + struct C *parent, *prev, *next; + int depth; + int min; + struct C *min_occ; +}; + +__attribute__((noipa)) struct C * +foo (int *node) +{ + struct A *p = __builtin_malloc (sizeof (struct C)); + if (!p) + return 0; + p->next = 0; + /* Originally placement new. */ + struct C *nw = (struct C *)(void *)p; + nw->of = node; + nw->parent = 0; + nw->prev = 0; + nw->next = 0; + nw->depth = 0; + nw->min_occ = nw; + nw->min = 0; + return nw; +} + +int +main () +{ + int o; + struct C *p = foo (&o); + if (p) + { + if (p->of != &o || p->parent || p->prev || p->next || p->depth + || p->min || p->min_occ != p) + __builtin_abort (); + } + __builtin_free (p); + return 0; +} diff --git a/gcc/testsuite/gcc.dg/store_merging_2.c b/gcc/testsuite/gcc.dg/store_merging_2.c index 19de3e2e0b5..8cd29f4243c 100644 --- a/gcc/testsuite/gcc.dg/store_merging_2.c +++ b/gcc/testsuite/gcc.dg/store_merging_2.c @@ -77,4 +77,4 @@ main (void) return 0; } -/* { dg-final { scan-tree-dump-times "Merging successful" 3 "store-merging" } } */ +/* { dg-final { scan-tree-dump-times "Merging successful" 2 "store-merging" } } */ -- 2.11.4.GIT