From 500fffe15de89d7b6f65511213d93150a368a752 Mon Sep 17 00:00:00 2001 From: rguenth Date: Wed, 15 Jan 2014 15:13:08 +0000 Subject: [PATCH] 2014-01-15 Richard Biener PR tree-optimization/59822 * tree-vect-stmts.c (hoist_defs_of_uses): New function. (vectorizable_load): Use it to hoist defs of uses of invariant loads out of the loop. * g++.dg/torture/pr59822.C: New testcase. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@206630 138bc75d-0d04-0410-961f-82ee72b054a4 --- gcc/ChangeLog | 7 +++++ gcc/testsuite/ChangeLog | 5 +++ gcc/testsuite/g++.dg/torture/pr59822.C | 14 +++++++++ gcc/tree-vect-stmts.c | 56 +++++++++++++++++++++++++++++++++- 4 files changed, 81 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/torture/pr59822.C diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f993e480f7b..7ddff756057 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2014-01-15 Richard Biener + + PR tree-optimization/59822 + * tree-vect-stmts.c (hoist_defs_of_uses): New function. + (vectorizable_load): Use it to hoist defs of uses of invariant + loads out of the loop. + 2014-01-15 Matthew Gretton-Dann Kugan Vivekanandarajah diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index dde78783d8d..1df5c3a66c2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2014-01-15 Richard Biener + + PR tree-optimization/59822 + * g++.dg/torture/pr59822.C: New testcase. + 2014-01-15 Kirill Yukhin PR target/59808 diff --git a/gcc/testsuite/g++.dg/torture/pr59822.C b/gcc/testsuite/g++.dg/torture/pr59822.C new file mode 100644 index 00000000000..7357b6dc383 --- /dev/null +++ b/gcc/testsuite/g++.dg/torture/pr59822.C @@ -0,0 +1,14 @@ +// { dg-do compile } + +typedef struct rtvec_def *rtvec; +enum machine_mode { VOIDmode }; +struct rtvec_def { void *elem[1]; }; +extern void *const_tiny_rtx[2]; +void +ix86_build_const_vector (enum machine_mode mode, bool vect, + void *value, rtvec v, int n_elt) +{ + int i; + for (i = 1; i < n_elt; ++i) + ((v)->elem[i]) = vect ? value : (const_tiny_rtx[(int) (mode)]); +} diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c index acdaa2db8af..820df7eddba 100644 --- a/gcc/tree-vect-stmts.c +++ b/gcc/tree-vect-stmts.c @@ -5480,6 +5480,59 @@ permute_vec_elements (tree x, tree y, tree mask_vec, gimple stmt, return data_ref; } +/* Hoist the definitions of all SSA uses on STMT out of the loop LOOP, + inserting them on the loops preheader edge. Returns true if we + were successful in doing so (and thus STMT can be moved then), + otherwise returns false. */ + +static bool +hoist_defs_of_uses (gimple stmt, struct loop *loop) +{ + ssa_op_iter i; + tree op; + bool any = false; + + FOR_EACH_SSA_TREE_OPERAND (op, stmt, i, SSA_OP_USE) + { + gimple def_stmt = SSA_NAME_DEF_STMT (op); + if (!gimple_nop_p (def_stmt) + && flow_bb_inside_loop_p (loop, gimple_bb (def_stmt))) + { + /* Make sure we don't need to recurse. While we could do + so in simple cases when there are more complex use webs + we don't have an easy way to preserve stmt order to fulfil + dependencies within them. */ + tree op2; + ssa_op_iter i2; + FOR_EACH_SSA_TREE_OPERAND (op2, def_stmt, i2, SSA_OP_USE) + { + gimple def_stmt2 = SSA_NAME_DEF_STMT (op2); + if (!gimple_nop_p (def_stmt2) + && flow_bb_inside_loop_p (loop, gimple_bb (def_stmt2))) + return false; + } + any = true; + } + } + + if (!any) + return true; + + FOR_EACH_SSA_TREE_OPERAND (op, stmt, i, SSA_OP_USE) + { + gimple def_stmt = SSA_NAME_DEF_STMT (op); + if (!gimple_nop_p (def_stmt) + && flow_bb_inside_loop_p (loop, gimple_bb (def_stmt))) + { + gimple_stmt_iterator gsi = gsi_for_stmt (def_stmt); + gsi_remove (&gsi, false); + gsi_insert_on_edge_immediate (loop_preheader_edge (loop), def_stmt); + } + } + + return true; +} + /* vectorizable_load. Check if STMT reads a non scalar data-ref (array/pointer/structure) that @@ -6384,7 +6437,8 @@ vectorizable_load (gimple stmt, gimple_stmt_iterator *gsi, gimple *vec_stmt, /* If we have versioned for aliasing then we are sure this is a loop invariant load and thus we can insert it on the preheader edge. */ - if (LOOP_REQUIRES_VERSIONING_FOR_ALIAS (loop_vinfo)) + if (LOOP_REQUIRES_VERSIONING_FOR_ALIAS (loop_vinfo) + && hoist_defs_of_uses (stmt, loop)) { if (dump_enabled_p ()) { -- 2.11.4.GIT